[ 
http://jira.magnolia-cms.com/browse/MAGNOLIA-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fabrizio Giustina resolved MAGNOLIA-3008.
-----------------------------------------

    Fix Version/s: 4.3
                       (was: 4.2.x)
       Resolution: Fixed

fixed with MAGNOLIA-3009

> Changes in the handling of url decoding in 4.2 break non-ascii urls that were 
> working properly in previous versions
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-3008
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3008
>             Project: Magnolia
>          Issue Type: Bug
>    Affects Versions: 4.2, 4.2.1, 4.2.2, 4.1.4, 4.2.3
>            Reporter: Fabrizio Giustina
>            Assignee: Fabrizio Giustina
>            Priority: Critical
>             Fix For: 4.3
>
>
> After upgrading from 4.1 to 4.2 (4.2.3) we saw several problems related to 
> url encoding, and looks like the changes in Magnolia 4.2 introduced some 
> regressions.
> The related jiras are:
> MAGNOLIA-2524 - AggregationState.decodeURI is wrong - review  
> MAGNOLIA-2899 - Make ServletDispatchingFilter i18n aware
> The problems: after 4.2 we were happily using virtual uris that were working 
> properly on non-ascii url, for example:
> {code}
> url: http://www.myserver.com/path/{test}
> VirtualURIMapping code:
> public MappingResult mapURI(String uri)
>     {
>           if (StringUtils.contains(uri, "{test}"))
>             {
>                 // do something
> {code}
> everything was used to work properly (and as expected) in magnolia < 4.2.  
> The above expression was correctly evaluated to :
> {code}
>           StringUtils.contains("http://www.myserver.com/path/${test}";, 
> "{test}")
> {code}
> After upgrading to 4.2 the url given to the virtualURI is
> http://www.myserver.com/path/%7Btest%7D
> And of course this break everything:
> {code}
>           StringUtils.contains("http://www.myserver.com/path/%7Btest%7D";, 
> "{test}")
> {code}
> This also happens with accented characters (àèìòù) which are very common in 
> italian. Also the path received by the cms filter is now undecoded: in the 
> past the path "/già" was ending in the request of the content "/già" in the 
> website repo (apart from the fact that magnolia strips accented characters 
> when creating pages from the admin interface this is perfectly legal in jcr, 
> and content loaded from xml with such paths was handled property by 
> magnolia)... now the HierarchyManager looks for /gi%something which is 
> definitively not good.
> *Note that this also happen after tweaking the tomcat connector to use UTF8* 
> (see http://wiki.magnolia-cms.com/display/DEV/URI+encoding+in+Tomcat ), which 
> is something that was needed in the past to get *parameters* in get correctly 
> decoded. 
> Unfortunately this looks like a blocker for the upgrade from 4.1 to 4.2, I 
> couldn't find any configuration that could restore the old behaviour and any 
> non-ascii url (for example we used a lot of SEO friendly virtualURIs which 
> mapped italian words...).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to