[ 
http://jira.magnolia-cms.com/browse/MAGNOLIA-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28639#action_28639
 ] 

Nickolaus Wing commented on MAGNOLIA-3214:
------------------------------------------

I'd really like to see this patch get picked up - it's essential for our 
sidebar strategy, which I'm hoping to be able to package up as a standalone 
module.

> pageIterator does not correctly replace the "current" node after it finishes 
> looping
> ------------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-3214
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3214
>             Project: Magnolia
>          Issue Type: Bug
>    Affects Versions: 4.3.1, 4.2.4
>            Reporter: Nickolaus Wing
>            Assignee: Boris Kraft
>         Attachments: pageIterator.patch
>
>
> pageIterator relies on 
> info.magnolia.cms.taglibs.Resource.restoreCurrentActivePage() to restore the 
> current node after execution.  However, restoreCurrentActivePage() simply 
> assumes that you wish to set getMainContent() as the current node.  It seems 
> more friendly to save off the current content node before execution, and 
> restore it afterwards.
> The included patch does exactly that.  File to be patched is 
> magnolia-taglib-cms/.../pageIterator.java.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------

Reply via email to