[
http://jira.magnolia-cms.com/browse/BLOSSOM-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=29977#action_29977
]
Tobias Mattsson commented on BLOSSOM-16:
----------------------------------------
Simulating forward and include requests is very fragile and will probably be
very hard to get working properly in all containers. There's no 100% reliable
solution and it will have to be tested in all containers to make sure that it
works.
Currently the only masquerading of the request that is performed is changing
request.getServletPath(). This isnt enough. It should change all 5 path info
getters. But getting that to play nicely with proper forwards is hard.
Blossom doesn't simulate includes at all now. When rendering with blossom from
inside an include its likely that Spring won't be able to resolve the
controller that is to be executed and will instead use the last include
requestUri.
The solution will have to be to do real include() and forward() onto
BlossomDispatcherServlet. But since the Magnolia filter chain doesn't handle
includes it will have to be mapped on its own in web.xml. It must also _not_ be
initialized if magnolia starts in install/update -mode. Perhaps it might even
need a filter chain of its own that initializes only when the install/update
phase is over. Which is a rather large undertaking. This issue has resulted in
discussions about have the magnolia filter chain handling include requests as
well, this would be a far easier solution.
> BlossomDispatcherServlet fails to render when handlerPath is a subset of the
> requestURI
> ---------------------------------------------------------------------------------------
>
> Key: BLOSSOM-16
> URL: http://jira.magnolia-cms.com/browse/BLOSSOM-16
> Project: Magnolia Blossom Module
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Tobias Mattsson
> Assignee: Tobias Mattsson
> Priority: Critical
> Fix For: 1.1.1
>
>
> The overriding of pathinfo to match the correct handler is not enough. It
> works but not for all cases. Needs to be changed to properly setup pathinfo
> on the request object. Either by changed the request uri or simulate an
> include, depending on what spring supports.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
