DialogDAM: Should be extendable for usage within data module - getDamSupport() 
should be protected
--------------------------------------------------------------------------------------------------

                 Key: MGNLSTK-721
                 URL: http://jira.magnolia-cms.com/browse/MGNLSTK-721
             Project: Magnolia Standard Templating Kit
          Issue Type: Improvement
          Components: controls
    Affects Versions: 1.3.5, 1.4
            Reporter: Christian Ringele
            Assignee: Ondřej Chytil
             Fix For: 1.3.x, 1.4
         Attachments: magnolia-module-standard-templating-kit.patch

For usage of the DAM Dialog/Control within the data module, the class 
DialogDAM.java should be expendable.
When using within the data module, the detection of a DAMSupport configuration 
out of a site definition can't work.
There for the method getDamSupport() should be protected, for providing a 
DAMSupport configuration from other places.
Second the access to the non existing DAMSupprt will result in a null violation 
within the constructor.
I have added comments to the code how I think it should be solved (always 
returning the default site definition at least).


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------

Reply via email to