[
http://jira.magnolia-cms.com/browse/MGNLSTK-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grégory Joseph updated MGNLSTK-725:
-----------------------------------
Description:
The current STK pom files declare a dependency to the forum module, which afaik
is not used nor needed. (It would be needed for commenting, which is only added
with the ETK)
Consequences:
* forum module is added to the stk-bundle (unneeded?)
* modules depending on stk transitively depend on the forum, thus requiring
several tedious exclusions.
For the record, here's the output of {{mvn dependency:analyze}}, which shows
more missing and superfluous dependencies (with a pinch of salt, as the
dependency to the taglib is needed, for instance - it's used in the template,
but not in code, which is why {{mvn dependency:analyze}} considers it unneeded)
{noformat}
[INFO] [dependency:analyze {execution: default-cli}]
[WARNING] Used undeclared dependencies found:
[WARNING] commons-lang:commons-lang:jar:2.4:provided
[WARNING] javax.jcr:jcr:jar:1.0:provided
[WARNING] org.slf4j:slf4j-api:jar:1.5.11:provided
[WARNING] commons-collections:commons-collections:jar:3.2.1:provided
[WARNING] rome:rome:jar:1.0:compile
[WARNING] log4j:log4j:jar:1.2.16:provided
[WARNING] info.magnolia:magnolia-gui:jar:4.4.1:provided
[WARNING] javax.servlet:servlet-api:jar:2.4:provided
[WARNING] commons-beanutils:commons-beanutils:jar:1.7.0:provided
[WARNING] info.magnolia:magnolia-module-exchange-simple:jar:4.4.1:provided
[WARNING] Unused declared dependencies found:
[WARNING] info.magnolia:magnolia-module-forum:jar:1.2.1:compile
[WARNING] org.easymock:easymockclassextension:jar:2.4:test
[WARNING] com.mockrunner:mockrunner:jar:0.3.1:test
[WARNING] info.magnolia:magnolia-module-fckeditor:jar:4.4.1:provided
[WARNING] info.magnolia:magnolia-taglib-utility:jar:4.4.1:provided
[WARNING] info.magnolia:magnolia-module-form:jar:1.2:compile
[WARNING] info.magnolia:magnolia-taglib-cms:jar:4.4.1:provided
[WARNING] cglib:cglib-full:jar:2.0.2:compile
[WARNING] javax.servlet:jsp-api:jar:2.0:provided
[WARNING] info.magnolia:magnolia-module-scheduler:jar:1.4:compile
{noformat}
Additionally, we also see side effects, for instance in user role bootstrap
files: {noformat}
$ grep -ri forum .
./src/main/resources/mgnl-bootstrap/standard-templating-kit/userroles.contact-base.xml:
<sv:node sv:name="acl_forum">
{noformat}
was:
The current STK pom files declare a dependency to the forum module, which afaik
is not used nor needed. (It would be needed for commenting, which is only added
with the ETK)
Consequences:
* forum module is added to the stk-bundle (unneeded?)
* modules depending on stk transitively depend on the forum, thus requiring
several tedious exclusions.
For the record, here's the output of {{mvn dependency:analyze}}, which shows
more missing and superfluous dependencies (with a pinch of salt, as the
dependency to the taglib is needed, for instance - it's used in the template,
but not in code, which is why {{mvn dependency:analyze}} considers it unneeded)
{noformat}
[INFO] [dependency:analyze {execution: default-cli}]
[WARNING] Used undeclared dependencies found:
[WARNING] commons-lang:commons-lang:jar:2.4:provided
[WARNING] javax.jcr:jcr:jar:1.0:provided
[WARNING] org.slf4j:slf4j-api:jar:1.5.11:provided
[WARNING] commons-collections:commons-collections:jar:3.2.1:provided
[WARNING] rome:rome:jar:1.0:compile
[WARNING] log4j:log4j:jar:1.2.16:provided
[WARNING] info.magnolia:magnolia-gui:jar:4.4.1:provided
[WARNING] javax.servlet:servlet-api:jar:2.4:provided
[WARNING] commons-beanutils:commons-beanutils:jar:1.7.0:provided
[WARNING] info.magnolia:magnolia-module-exchange-simple:jar:4.4.1:provided
[WARNING] Unused declared dependencies found:
[WARNING] info.magnolia:magnolia-module-forum:jar:1.2.1:compile
[WARNING] org.easymock:easymockclassextension:jar:2.4:test
[WARNING] com.mockrunner:mockrunner:jar:0.3.1:test
[WARNING] info.magnolia:magnolia-module-fckeditor:jar:4.4.1:provided
[WARNING] info.magnolia:magnolia-taglib-utility:jar:4.4.1:provided
[WARNING] info.magnolia:magnolia-module-form:jar:1.2:compile
[WARNING] info.magnolia:magnolia-taglib-cms:jar:4.4.1:provided
[WARNING] cglib:cglib-full:jar:2.0.2:compile
[WARNING] javax.servlet:jsp-api:jar:2.0:provided
[WARNING] info.magnolia:magnolia-module-scheduler:jar:1.4:compile
{noformat}
Additionally, we also see side effects, for instance in user role bootstrap
files: {noformat}
{noformat}
$ grep -ri forum .
./src/main/resources/mgnl-bootstrap/standard-templating-kit/userroles.contact-base.xml:
<sv:node sv:name="acl_forum">
{noformat}
> Dependencies
> ------------
>
> Key: MGNLSTK-725
> URL: http://jira.magnolia-cms.com/browse/MGNLSTK-725
> Project: Magnolia Standard Templating Kit
> Issue Type: Improvement
> Components: build
> Affects Versions: 1.4.1
> Reporter: Grégory Joseph
> Assignee: Ondřej Chytil
> Fix For: 1.3.6, 1.4.2
>
>
> The current STK pom files declare a dependency to the forum module, which
> afaik is not used nor needed. (It would be needed for commenting, which is
> only added with the ETK)
> Consequences:
> * forum module is added to the stk-bundle (unneeded?)
> * modules depending on stk transitively depend on the forum, thus requiring
> several tedious exclusions.
> For the record, here's the output of {{mvn dependency:analyze}}, which shows
> more missing and superfluous dependencies (with a pinch of salt, as the
> dependency to the taglib is needed, for instance - it's used in the template,
> but not in code, which is why {{mvn dependency:analyze}} considers it
> unneeded)
> {noformat}
> [INFO] [dependency:analyze {execution: default-cli}]
> [WARNING] Used undeclared dependencies found:
> [WARNING] commons-lang:commons-lang:jar:2.4:provided
> [WARNING] javax.jcr:jcr:jar:1.0:provided
> [WARNING] org.slf4j:slf4j-api:jar:1.5.11:provided
> [WARNING] commons-collections:commons-collections:jar:3.2.1:provided
> [WARNING] rome:rome:jar:1.0:compile
> [WARNING] log4j:log4j:jar:1.2.16:provided
> [WARNING] info.magnolia:magnolia-gui:jar:4.4.1:provided
> [WARNING] javax.servlet:servlet-api:jar:2.4:provided
> [WARNING] commons-beanutils:commons-beanutils:jar:1.7.0:provided
> [WARNING] info.magnolia:magnolia-module-exchange-simple:jar:4.4.1:provided
> [WARNING] Unused declared dependencies found:
> [WARNING] info.magnolia:magnolia-module-forum:jar:1.2.1:compile
> [WARNING] org.easymock:easymockclassextension:jar:2.4:test
> [WARNING] com.mockrunner:mockrunner:jar:0.3.1:test
> [WARNING] info.magnolia:magnolia-module-fckeditor:jar:4.4.1:provided
> [WARNING] info.magnolia:magnolia-taglib-utility:jar:4.4.1:provided
> [WARNING] info.magnolia:magnolia-module-form:jar:1.2:compile
> [WARNING] info.magnolia:magnolia-taglib-cms:jar:4.4.1:provided
> [WARNING] cglib:cglib-full:jar:2.0.2:compile
> [WARNING] javax.servlet:jsp-api:jar:2.0:provided
> [WARNING] info.magnolia:magnolia-module-scheduler:jar:1.4:compile
> {noformat}
> Additionally, we also see side effects, for instance in user role bootstrap
> files: {noformat}
> $ grep -ri forum .
> ./src/main/resources/mgnl-bootstrap/standard-templating-kit/userroles.contact-base.xml:
> <sv:node sv:name="acl_forum">
> {noformat}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
