[
http://jira.magnolia-cms.com/browse/MAGNOLIA-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Bärfuss updated MAGNOLIA-3591:
--------------------------------------
Patch included: [Yes]
Fix Version/s: 4.4.3
Thanks for all the debugging
> Original previewMode is forgotten when Exception in Paragraph
> -------------------------------------------------------------
>
> Key: MAGNOLIA-3591
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3591
> Project: Magnolia
> Issue Type: Bug
> Components: core
> Affects Versions: 4.4.2
> Reporter: Kimmo Björnsson
> Assignee: Philipp Bärfuss
> Fix For: 4.4.3
>
>
> When I use noEditBars="true" and the Paragraph throws an Exception all
> paragraphs afterwards get no edit-bar.
> I found that the last part that restores the previewMode is not run when an
> Exception is thrown in this code.
> ---
> if(noEditBars && !orgShowPreview){
> aggregationState.setPreviewMode(true);
> }
> if (this.path != null) { // TODO
> log.warn("You are using the deprecated path attribute
> of the include tag. Your jsp will be included for now, but you might
> want to update your code to avoid bad surprises in the future.");
> pageContext.include(this.path);
> } else {
> WebContext webContext = MgnlContext.getWebContext();
> webContext.setPageContext(pageContext);
> webContext.push((HttpServletRequest)pageContext.getRequest(),
> (HttpServletResponse)pageContext.getResponse());
> try {
> renderingEngine.render(content, pageContext.getOut());
> } finally{
> webContext.pop();
> webContext.setPageContext(null);
> }
> }
> if(noEditBars){
> aggregationState.setPreviewMode(orgShowPreview);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------