Text fields group has a non required 'group name' but without it the internal 
fields are not used
-------------------------------------------------------------------------------------------------

                 Key: MGNLFORM-98
                 URL: http://jira.magnolia-cms.com/browse/MGNLFORM-98
             Project: Magnolia Form Module
          Issue Type: Bug
    Affects Versions: 1.2.3
            Reporter: Tobias Mattsson
            Assignee: Tobias Mattsson


The edit group field adds a set of edit fields within a group. In the dialog it 
asks for a group name which is indicated to be optional. The group name is in 
fact the controlName of the field. When binding the form will look at this 
paragraph and test for the controlName, if it's not there it will skip the 
paragraph, and all the fields it contains. If it's there it will be part of the 
form data with an empty value and its children will be bound as well.

We should either, remove the requirement of having a controlName on this field. 
Or clearly indicate that it's required, although binding it to the form data 
serves no purpose.

Note that the group name is also used as an id to the div containing the edit 
fields.


Original report from user-list:
{quote}
I think to have found a bug inside [1]
When you build a groupEditField you can AVOID to insert a controlName property 
because in the dialog is not "required".
Even if you insert it, the "value" when you submit the form is empty.

If the controlName property is not present, the field is skipped.

AND

the validation checks on the following lines (110 and 113) prevents to "look 
inside" the "edits" node to find nested fields.

SOLUTION (tested):
put the last part of if/else-if/else-if outside the "if" as shown on [2]

------------------------------
[1] 
http://svn.magnolia-cms.com/view/community/modules/magnolia-module-form/trunk/src/main/java/info/magnolia/module/form/paragraphs/models/DefaultFormDataBinder.java

[2] http://pastebin.com/yGKSNCMH

HTH to anybody else (and maybe next MGNL form module versions!!!)

Matteo
{quote}


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to