[ 
http://jira.magnolia-cms.com/browse/MGNLGROOVY-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Grégory Joseph reopened MGNLGROOVY-51:
--------------------------------------


A few remarks from my side:
* make any constructor-initialized field {{final}} - shows that it's immutable.
* the {{console}} field seems superfluous. Pass it to the {{executeScript}} 
method, or just initialize it in the method itself.
* try to throw and catch more specific exceptions if possible. If the using 
{{Exception}} is unavoidable, I'd recommend a little inline comment to explain 
why that is to developers reading that code later.

> New Groovy VersionHandling Task. This Task execute a groovy file furing 
> version upgrate.  
> ------------------------------------------------------------------------------------------
>
>                 Key: MGNLGROOVY-51
>                 URL: http://jira.magnolia-cms.com/browse/MGNLGROOVY-51
>             Project: Magnolia Groovy Module
>          Issue Type: Task
>          Components: integration
>    Affects Versions: 2.0
>            Reporter: Eric Hechinger
>            Assignee: Eric Hechinger
>             Fix For: 2.0
>
>
> Creation of a ExecuteGroovyFileTask that extends AbstractTask. This Task 
> take's as input parameter a Groovy file name, and execute it agains the 
> MgnlGroovyConsole. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to