[ 
http://jira.magnolia-cms.com/browse/MAGNOLIA-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Mattsson reopened MAGNOLIA-4639:
---------------------------------------


* Link
** please change variable name repoName to workspaceName
** throw RuntimeRepositoryException instead of RuntimeException
** constructor Link(Node) doesn't throw RepositoryException as javadoc claims
** method initLink, javadoc refers to not present parameter content
** shouldn't we rename field repository to workspace and handle to path, 
provide new getters and setters, and keep the old ones for backwards 
compatibility
* LinkUtil
** change variable name from repository to workspanceName
** complete or remove javadoc like this:
{code}
    /**
     * 
     * @param nodeData
     * @return
     * @throws LinkException
     * @deprecated
     */
{code}
** some @param directives in javadoc refer to parameters that dont exist, 
usually nodeDate when it should be node
** toPattern, javadoc is incorrect, it doesn't throw RepositoryException


> Link API update
> ---------------
>
>                 Key: MAGNOLIA-4639
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-4639
>             Project: Magnolia
>          Issue Type: Improvement
>      Security Level: Public
>    Affects Versions: 5.0 Alpha1 s008
>            Reporter: Ondřej Chytil
>            Assignee: Ondřej Chytil
>             Fix For: 5.0 Alpha1 s009
>
>
> There is still some code refactoring needed in Link related classes (Link, 
> LinkUtil...).
> - Code is not yet 100% converted to use Node/Property API.
> - Javadoc needs to be updated for deprecated methods.
> - Tests are still using expectation to old API.
> - Also few improvements of methods logic while handling with old API cases 
> (NodeData/binary NodeData).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       


----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to