[
http://jira.magnolia-cms.com/browse/MGNLMIGRATION-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Haderka reopened MGNLMIGRATION-113:
---------------------------------------
MigrateTemplateExecuteScripts.groovy
{noformat}
16 modulesMap = ["standard-templating-kit",
"/Users/erichechinger/Dev/Temp/templates/templating-kit"]
{noformat}
That doesn't seem right, does it?
JspTemplate
{noformat}
788
789 // TODO: attributes.get("items")
790
1132 if (!path.isEmpty()) {
1133 //FIXME: ctx variable is not exposed?!
1204 //FIXME: relative link
1205 }
1206
1207 //TODO escapeXml, lineBreak, dateLanguage, scope
{noformat}
Pls no more todo's or fixme's - create tickets for those things if you can't do
them directly.
FreemarkerTemplate:
{noformat}
468 if (t.data.equals("@cmsu.table")) {
469 //do tables manually, lazy
470 // TODO
471 }
472
473 if (t.data.equals("@cmsu.xmp")) {
474 // TODO
475 }
864
865 // TODO: attributes.get("items")
866
{noformat}
The least you should do is spit out a warning about those not being migrated.
{noformat}
933 if (!newBarExists) {
934 //if (!areaTag.isArea) {
935 markAsArea(this.root, areaName, t, t);
936 t.addAfter(areaTag);
937 //}
{noformat}
IF the code is worng them remove it, don't leave it in commented out.
{noformat}
1280 //FIXME: relative link
1281 }
1282
1283 if (attributes.containsKey("defaultValue")) {
1284 defaultValue = "!" +
wrapNull(attributes.get("defaultValue"));
1285 } else {
1286 defaultValue = "!";
1287 }
1288
1289 //TODO escapeXml, lineBreak, dateLanguage, scope
{noformat}
... more todo's and fixme's
JSPTemplate
{noformat}
197 // todo?
{noformat}
dunno, you tell me?
{noformat}
395 if (t.data.equals("cmsu:table")) {
396 //do tables manually, lazy
397 // TODO
398 }
399
400 if (t.data.equals("cmsu:xmp")) {
401 // TODO
402 }
{noformat}
same as above - at the very least print warning.
TemplateScriptParser
{noformat}
95 if (!file.exists()) {
96 // l.logM("Template script not found! " + absolutePath, 1)
TODO MGNLMIGRATION-75:
97 return;
{noformat}
if you are not going to print this message then remove the code ... btw
MGNLMIGRATION-75 is resolved, but this file is not modified under that ticket.
> Migrate TemplateScripts Task: Move Groovy Class into Java Class
> ---------------------------------------------------------------
>
> Key: MGNLMIGRATION-113
> URL: http://jira.magnolia-cms.com/browse/MGNLMIGRATION-113
> Project: Magnolia Migration
> Issue Type: Sub-task
> Affects Versions: 1.1.3
> Reporter: Eric Hechinger
> Assignee: Cesar Desales
> Fix For: 1.2
>
>
> Groovy class:
> TemplateScript and MigrateTemplateScripts should be moved into Java service.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
