[
http://jira.magnolia-cms.com/browse/MGNLUI-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Espen Jervidalo updated MGNLUI-192:
-----------------------------------
Summary: Review, Document and Improve Choose Dialog (was: Review,
Document and Improve naming of Choose Dialog)
Description:
The ChooseDialog structure and related code has grown over time naturally. In
order to make this structure, it's purpose and use easy to understand to other
developers writing their own apps we need to
- review naming of the classes
- review javadoc
- document the structure and it's use in architecture documents & diagrams
- provide parallels or examples of where how this structure is used and what is
intended use
- restructure the code to minimize duplication and simplify creation of such
dialogs
Idea: Instead of getting the app from the appController and then creating the
presenter and opening it manually, this should be abstracted by the
appController: appController.openChooseDialog("app name")
Currently there is only one chooseDialog per app. Better per subApp?
was:
The ChooseDialog structure and related code has grown over time naturally. In
order to make this structure, it's purpose and use easy to understand to other
developers writing their own apps we need to
- review naming of the classes
- review javadoc
- document the structure and it's use in architecture documents & diagrams
- provide parallels or examples of where how this structure is used and what is
intended use
- restructure the code to minimize duplication and simplify creation of such
dialogs
> Review, Document and Improve Choose Dialog
> ------------------------------------------
>
> Key: MGNLUI-192
> URL: http://jira.magnolia-cms.com/browse/MGNLUI-192
> Project: Magnolia UI
> Issue Type: Improvement
> Security Level: Public
> Components: forms, framework
> Reporter: Jan Haderka
> Assignee: Tobias Mattsson
> Priority: Critical
> Fix For: 5.0 Alpha2 s011
>
>
> The ChooseDialog structure and related code has grown over time naturally. In
> order to make this structure, it's purpose and use easy to understand to
> other developers writing their own apps we need to
> - review naming of the classes
> - review javadoc
> - document the structure and it's use in architecture documents & diagrams
> - provide parallels or examples of where how this structure is used and what
> is intended use
> - restructure the code to minimize duplication and simplify creation of such
> dialogs
> Idea: Instead of getting the app from the appController and then creating the
> presenter and opening it manually, this should be abstracted by the
> appController: appController.openChooseDialog("app name")
> Currently there is only one chooseDialog per app. Better per subApp?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
