Workbench resync is messy
-------------------------
Key: MGNLUI-510
URL: http://jira.magnolia-cms.com/browse/MGNLUI-510
Project: Magnolia UI
Issue Type: Bug
Security Level: Public
Components: content app
Reporter: Mikael Geljic
Assignee: Mikael Geljic
Fix For: 5.0 Alpha2 s011
on subApp startup or location change, the workbench needs to be restored to
reflect the potentially new location. This is currently handled in the
following order:
1. {{AbstractContentSubApp#restoreWorkbench}}
2. {{ContentWorkbenchPresenter#resynch}}
3. {{ContentWorkbenchView#resync}}
4. back to {{ContentWorkbenchPresenter#onSearch}} - fires a SearchEvent
4b. location has a chance to be updated, which is not needed when restoring
the workbench
5. handler in presenter triggers {{ContentWorkbenchPresenter#doSearch}}
6. optionally do {{ContentWorkbenchView.resync}}
The main problem is that on workbench restore there is a lot of back and forth
logic between view and presenter, also even between the presenter and the event
bus. Search UI logic was then also spread between view and presenter.
Conceptually, the presenter gets its state and updates the view, the view
should not fire things back to presenter in a programmatic way - but only
following user interaction, e.g. search field value change, not workbench
restore.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
