[
http://jira.magnolia-cms.com/browse/MGNLMIGRATION-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samuel Schmitt updated MGNLMIGRATION-206:
-----------------------------------------
Summary: Inheritance - it should not be configured in a page definition
but only in the site definition (was: Config migration: inconsistent behavior
for inheritance & unnecessary placement)
Description:
As we set by default an inheritance configuration on all extra nodes (site def
and pages template), this has a drawback when we want to change the default
setting.
Let's say by default it's on "components=all" and i want "components =
filtered". I have to update the sitedef and remove it form all the pages
templates.
For this reason we must just put the inheritance config in the site def.
After the config migration two issues occur:
1) First of all, there is an unnecessary placement of an inheritance node for
the attached screenshot for the extras and promos areas. The original config
just sets extras and promos to {{enabled=false}}, so there should be no
inheritance node (or even class property) present since all of these settings
are present in the site definition (also attached).
2) Secondly, there is an inconsistent behavior in setting the inheritance node
between extras and promos where it is just an empty node > very ugly and
unclear why this happens.
was:
After the config migration two issues occur:
1) First of all, there is an unnecessary placement of an inheritance node for
the attached screenshot for the extras and promos areas. The original config
just sets extras and promos to {{enabled=false}}, so there should be no
inheritance node (or even class property) present since all of these settings
are present in the site definition (also attached).
2) Secondly, there is an inconsistent behavior in setting the inheritance node
between extras and promos where it is just an empty node > very ugly and
unclear why this happens.
> Inheritance - it should not be configured in a page definition but only in
> the site definition
> ----------------------------------------------------------------------------------------------
>
> Key: MGNLMIGRATION-206
> URL: http://jira.magnolia-cms.com/browse/MGNLMIGRATION-206
> Project: Magnolia Migration
> Issue Type: Bug
> Affects Versions: 1.2
> Reporter: Natascha Desmarais
> Fix For: 1.2.1
>
> Attachments:
> config.modules.extended-templating-kit.config.sites.update-training.xml,
> migration_inheritance_behavior.png
>
>
> As we set by default an inheritance configuration on all extra nodes (site
> def and pages template), this has a drawback when we want to change the
> default setting.
> Let's say by default it's on "components=all" and i want "components =
> filtered". I have to update the sitedef and remove it form all the pages
> templates.
> For this reason we must just put the inheritance config in the site def.
> After the config migration two issues occur:
> 1) First of all, there is an unnecessary placement of an inheritance node for
> the attached screenshot for the extras and promos areas. The original config
> just sets extras and promos to {{enabled=false}}, so there should be no
> inheritance node (or even class property) present since all of these settings
> are present in the site definition (also attached).
> 2) Secondly, there is an inconsistent behavior in setting the inheritance
> node between extras and promos where it is just an empty node > very ugly and
> unclear why this happens.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
