[
http://jira.magnolia-cms.com/browse/MGNLMIGRATION-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Haderka reopened MGNLMIGRATION-80:
--------------------------------------
- I fail to see how is
[this|http://git.magnolia-cms.com/gitweb/?p=modules/4-5-migration.git;a=blobdiff;f=src/main/java/info/magnolia/templatingkit/migration/util/MigrationUtil.java;h=3e14ba43c013e6a9625dade595d6012560ae0472;hb=fa017f6f53a544c3d414c158db21f80509d78339;hp=464a900172e2413d52434718f5d7aee78c2b74de;hpb=d3d1bc905e6cb96e263e3438f8422587aa9bb78d]
useful. Can you explain (or better remove it)?
- {{MigrationUtil.groovy)) {{travelExtends()}} method. What is this name? Where
do you want to have extend to travel? If I got right what it does, it should be
call {{traverseExtendsNodeHierarchy()}} or similar, but not {{travel}}.
- {{TemplateScript.groovy}} please stop using one letter variables in the code
such as {code}
LogUtil l
{code}
and no, renaming it to {{lu}} is not ok either. Think of anyone who will have
to read this code and maintain it half a year later.
- {{TemplateScriptParser.java}} - rather then commenting out exception, remove
it and add comment explaining why returning null in this case is what we want
to do.
{code}
if (isSTKTemplateScript(templateScriptPath)) {
- throw new Exception("Extending STK script!");
+ //throw new Exception("Extending STK script!");
+ return null;
}
{code}
General remark:
- if you want to reorder methods in the code, do it in separate commit and make
sure commit message explains it. It is nearly impossible to look at one letter
changes in the code between hundreds of reordered lines.
> When using template script from Magnolia modules, provide areas of these
> templates without parsing the FTL.
> -----------------------------------------------------------------------------------------------------------
>
> Key: MGNLMIGRATION-80
> URL: http://jira.magnolia-cms.com/browse/MGNLMIGRATION-80
> Project: Magnolia Migration
> Issue Type: Sub-task
> Reporter: Robert Šiška
> Assignee: Robert Šiška
> Fix For: 1.2.1
>
>
> In the time of running migration tool on custom project, all the Magnolia
> modules like stk, form or pur can be already migrated.
> When custom modules use FTLs from these modules, areas should be "detected"
> without need of parsing the old versions of these FTLs.
> Also, when extending template definition with area, copy the area definition
> and add available components.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
