![]() |
|
|
|
|
Change By:
|
Christopher Zimmermann
(06/Mar/13 3:51 PM)
|
|
Description:
|
There is code in multiple places for these activities. Some of the code should be consolidated into a utility class. Please analyze and discuss with architects.
Definitely unify:
DefaultImageProvider.resolveFileTypeFromMimeType()
FileItemWrapper.resolveFileTypeFromMimeType()
And:
DefaultImageProvider.isImage()
FileItemWrapper.isImage()
Also Consider:
FileItemWrapper.ResolveMediaTypeFromMimeType()
The difference is that FileType includes all of the files that we have icons for. Do we want to do this? Should it be a different name? IconfileType?
This is
also handled in DAM with Voters and configuration. Would it make sense to move this functionality out of dam? so that it could be used for files in general? Maybe this implementation can replace the above functions.
DamModule.getMediaTypeForMimeType()
This is
very much related to: http://jira.magnolia-cms.com/browse/MGNLUI-213
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <
[email protected]>
----------------------------------------------------------------
