[magnolia-dev] [JIRA] (MAGNOLIA-5029) Components with areas does not behave as expected on a public instance: areas are displayed even if they are empty

[JIRA (on behalf of Jan Haderka)]

Jan Haderka reopened MAGNOLIA-5029 Components with areas does not behave as expected on a public instance: areas are displayed even if they are empty just a tiny thing, but helps to understand the code next time there's some bug to fix: if (!((AreaDefinition.TYPE_LIST.equals(areaDefinition.getType()) || AreaDefinition.TYPE_SINGLE.equals(areaDefinition.getType())) && numberOfComponents < 1)) { 272 is not really easy to read, partly because it is long and partly because of the negation of the whole statement. Can we maybe just swap if/else parts of the code below so the test _expression_ doesn't have to be negated? Also IIRC expressions are evaluated left to right so I would put the simple (numberOfComponents < 1) test first because if that is not satisfied, there's no need to evaluate the rest ... but that's really nitpicking. Thx. Change By: Jan Haderka (15/May/13 1:01 PM) Resolution: Fixed Status: Resolved Reopened

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

---

----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------