![]() |
|
|
|
|
Change By:
|
Grégory Joseph
(13/Jun/13 3:56 PM)
|
|
Summary:
|
Responses served from cache can throw a RuntimeException that should be ignored (
Occasional broken pipe for DINWebPro.woff
)
|
|
Patch included:
|
Yes
|
|
Description:
|
h2. Cause and proposed fix
When a request is interrupted (by the browser), containers typically throw a subclass of IOException (Tomcat throws a {{org.apache.catalina.connector.ClientAbortException}}, Jetty throws an {{org.mortbay.jetty.EofException}}, ...). We already treat this in a few places: (look for {{catch (IOException)}} snippet)
* {{info.magnolia.rendering.engine.RenderingFilter#doFilter}}
* {{info.magnolia.rendering.engine.RenderingFilter#handleResourceRequest}}
* {{info.magnolia.cms.servlets.ClasspathSpool#streamSingleFile}}
We could do the exact same thing in {{CacheFilter}}. We already catch all exceptions; checking if it's an IO and swallowing it there isn't perfect or ideal, but at least it'll be consistent with the rest. (In this specific case we need to make we still unlock the cache if needed)
h2. Proposed improvements
h2. Symptoms
bundle (integration tests) occasionally fail because of the following error:
{code}
[INFO] [talledLocalContainer] 2013-06-13 06:31:55,647 ERROR info.magnolia.module.cache.filter.CacheFilter : A request started to cache but failed with an exception (IOException: Broken pipe). [url="">[WARNING] [talledLocalContainer] 2013-06-13 06:31:55.676:WARN::/magnoliaTestPublic/.resources/defaultLoginForm/css/fonts/DINWebPro.woff
[WARNING] [talledLocalContainer] java.lang.RuntimeException: org.mortbay.jetty.EofException
{code}
This sometimes also happens locally now...
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <
[email protected]>
----------------------------------------------------------------
