[magnolia-dev] [JIRA] (MGNLUI-2236) Label of subapps is ignored

Fri, 04 Oct 2013 06:28:03 -0700

Issue Type: Bug Bug
Assignee: Unassigned
Attachments: m01.png, m02.png
Created: 04/Oct/13 3:21 PM
Description: 
Version number : 5.1 (Snapshot: 2013.10.04 08:02:58)
Build          : 4. October 2013 (rev. a33e11d74c2fa8d08268293854dd38e7556a35f3)
Edition        : Enterprise Edition



Steps to reproduce:


    
	
  • go to configuration/modules/about-app/apps/about/subApps/main
    • 
	
  • add property label and set its value
    • 
	
  • open about app
    • 
	
  •  label hasn't changed to the one defined in the subapp
    • 





See also attached screenshots.



Debugging leads to the getCaption() method in the info.magnolia.ui.framework.app.BaseSubApp.




    /**
     * This method will try to determine the current sub app caption, the one usually displayed in the tab where the subapp opens.
     *
     * @return the configured label for this subapp. If no label is found in the subapp configuration, it will try to use the label from the parent app.
     *         If the latter is missing too, it will return an empty string.
     */
    @Override
    public String getCaption() {
        String label = subAppContext.getSubAppDescriptor().getLabel();
        if (StringUtils.isNotBlank(label)) {
            return label;
        }
        label = subAppContext.getAppContext().getLabel();
        if (StringUtils.isNotBlank(label)) {
            return label;
        }
        log.warn("No label could be found for sub app [{}] in app [{}]", subAppContext.getSubAppDescriptor().getName(), subAppContext.getAppContext().getName());
        return "";
    }






String label = subAppContext.getSubAppDescriptor() returns proxied subapp descriptor that then returns label of the main app, not subapp (btw getLabel() method in the subapp gets invoked and returns correct label).
Fix Versions: 5.1.1
Project: Magnolia UI
Priority: Neutral Neutral
Reporter: Jaroslav Simak
Security Level: Public
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to