-- Jan On 09 Jan 2014, at 15:08, Unger, Richard <[email protected]> wrote:
> Hi Magnolians,
>
> magnolia-enterprise-webapp 5.2.1 pulls in
> magnolia-module-legacy-admininterface 5.0.2 via magnolia-bundled-webapp,
> magnolia-empty-webapp and magnolia-module-cache…. that definitely seems to
> be an error, it should be version 5.2.1. This error requires us to add the
> dependency explicitly to our WAR overlay, so please correct this…
>
> Also:
> magnolia-module-legacy-admininterface 5.2.1 has an incorrect dependency on
> magnolia-i18n 5.2 (should be 5.2.1).
> magnolia-module-legacy-admininterface 5.2.1 has an incorrect dependency on
> magnolia-rendering 5.2 (should be 5.2.1).
> This forces you to additionally write an excludes when adding
> magnolia-module-legacy-admininterface. :-(
did we actually released legacy w/ 5.2.1? Hmm, i thought we did not. Anyway
those dependencies should not matter as the ones from the bundle itself are
closer and should be resolved up correctly. Can I see your pom and output of
mvn dependency:tree ?
>
> magnolia-module-groovy 2.2.1 has an incorrect dependency on magnolia-ui-api
> 5.2 (should be 5.2.1).
> magnolia-module-groovy 2.2.1 has an incorrect dependency on
> magnolia-ui-contentapp 5.2 (should be 5.2.1).
>
> magnolia-module-activation 5.2.1 has incorrect dependency on magnolia-ui-api
> 5.2 (should be 5.2.1).
>
> magnolia-contacts 1.2 (pulled in by magnolia-bundled-webapp) should be bumped
> to 1.2.1 and dependency on magnolia-ui-contentapp bumped to 5.2.1.
>
> magnolia-module-standard-templating-kit 2.7.1 has incorrect dependency on
> magnolia-module-rssaggregator 2.2 (should be 2.2.1).
> magnolia-module-standard-templating-kit 2.7.1 has incorrect dependency on
> magnolia-module-forum 3.2 (should be 3.2.1).
> magnolia-module-standard-templating-kit 2.7.1 has incorrect dependency on
> magnolia-module-form 2.1 (should be 2.2.1).
> magnolia-module-standard-templating-kit 2.7.1 has incorrect dependency on
> magnolia-module-inplace-templating 2.2 (should be 2.2.1).
> magnolia-module-standard-templating-kit 2.7.1 has incorrect dependency on
> magnolia-module-imaging 3.0.2 (should be 3.0.3).
> magnolia-module-standard-templating-kit 2.7.1 has incorrect dependency on
> magnolia-module-resources 2.2 (should be 2.2.1).
> è Basically, it looks like you didn’t update any of these dependencies for
> the release!?!?
>
> magnolia-module-imaging is also included incorrectly (3.0.1) via
> magnolia-ui-admincentral.
>
> magnolia-module-rssaggregator 2.2.1 has incorrect dependency on magnolia-dam
> 1.2 (should be 1.2.1).
>
> magnolia-module-resources 2.2.1 has incorrect dependency on magnolia-ui-form
> 5.2 (should be 5.2.1).
>
> magnolia-module-mail 5.1.1 has incorrect dependency on magnolia-dam 1.1
> (should be 1.2.1).
and similar for all other dependencies … it should be resolved up by maven w/o
need to reconfigure every single module to latest by us for every release.
> Also, there is a problem with tika-core:
> magnolia-enterprise-webapp gets version 1.3 via jackrabbit-core, but needs
> version 1.4 to match tika-parsers 1.4 pulled in by magnolia-empty-webapp. You
> should add an explicit dependency on tika-core-1.4, and add exclude rules for
> the 1.3 versions…
I just built my own web app based on magnolia-enterprise-webapp 5.2.1 and i get
tika-parsers 1.4 as i would expect … can you share your pom?
> Finally I note both antlr-2.7 and antlr-3.3 are both pulled in, both JARs get
> included in the webapp. Is that necessary and deliberate?
yes, antlr is silly that way and 3.3 depends on 2.7
> I have to say, it is quite annoying to have to manually check the
> dependencies each time we up the version number in magnolia.
> I think there seems to be some problem with the way the releases are made.
> Clearly you developers at magnolia are getting the correct dependencies by
> some other method, or you would not be releasing the code as it is (since it
> doesn’t run).
> The question is, is there something wrong with my maven setup, or are people
> just being lazy at your end?
definitively not lazy and not deliberate. Most likely we pull web app together
differently.
this is what i use in pom responsible for building war:
…
<dependencies>
<dependency>
<groupId>info.magnolia.eebundle</groupId>
<artifactId>magnolia-enterprise-webapp</artifactId>
<type>pom</type>
</dependency>
<dependency>
<groupId>info.magnolia.eebundle</groupId>
<artifactId>magnolia-enterprise-webapp</artifactId>
<type>war</type>
</dependency>
<dependency>
<groupId>test.blahm.module1</groupId>
<artifactId>blah-module1</artifactId>
<type>jar</type>
<version>1.0-SNAPSHOT</version>
</dependency>
…
signature.asc
Description: Message signed with OpenPGP using GPGMail
