![]() |
|
|
|
|
Change By:
|
Grégory Joseph
(03/Apr/14 6:39 PM)
|
|
Description:
|
The pom files of these 2 modules currently configures {{maven-jar-plugin}} to generate an {{INDEX.LIST}} which is turn causing some build issues on some platforms. There is no reason for these jar entries to be there, and that configuration seems to have been copy-paste accidentally from some example. (AFAICT, it's been introduced in the m5-vaadin prototype, with {{m5-magnolia-shell}} in commit {{118311761ba}}, and copied over multiple places since - and that in turn seems to come from the Vaadin-widget-project Maven archetype)
It should look like this:
{noformat}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<!-- Remove this line: <index>true</index>-->
<manifest>
<!-- Remove this line: <addClasspath>true</addClasspath> -->
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
<manifestEntries>
<Vaadin-Package-Version>1</Vaadin-Package-Version>
<Vaadin-Widgetsets>
info.magnolia.ui.vaadin.editor.gwt.PageEditorWidgetSet
</Vaadin-Widgetsets>
</manifestEntries>
</archive>
</configuration>
</plugin>
{noformat}
(i.e remove {{<index>}} as well as {{<addClasspath>}}, which makes no sense for us either)
This seems to fix issues with running integration tests on different machines
(specifically
,
the issue where jsp compilation, for some reason, triggered {{InvalidJarIndexException}}s),
so should allow our build infrastructure to grow faster, once fixed.
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <
[email protected]>
----------------------------------------------------------------
