![]() |
|
|
|
|
Change By:
|
Christopher Zimmermann
(22/Apr/14 3:19 PM)
|
|
Description:
|
To reproduce:
* Select an asset.
* Click "Move asset" action.
> Dialog opens.
* Select a new location in the dialog.
* Hit ENTER key.
> Red error bar appears - in pulse is message "An error occurred while executing an action. No definition exists for action: commit."
However if you press the "MOVE INSIDE" button, the item is moved as expected.
The problem relates to the fact that the ENTER keyboard attempts to trigger the action named "commit" which most dialogs have. (See BaseDialogPresenter#CommitDialogShortcutListener).
Move dialog (see MoveDialogPresenterImpl) actually has three actions. The button that *looks* like the commit simply has a "commit" css class added to it.
The complexity is that the MOVE INSIDE is only applicable if a user has selected a directory. So what SHOULD happen if user hits ENTER? MOVE BEFORE action triggered?
Perhaps ENTER key should not be supported here.
Perhaps the code throwing the exception should check for "commit" action and skip the exeption in that case.
ERROR a.ui.contentapp.movedialog.MoveDialogPresenterImpl: An error occurred while executing an action.
info.magnolia.ui.api.action.ActionExecutionException: No definition exists for action: commit
at info.magnolia.ui.api.action.AbstractActionExecutor.createAction(AbstractActionExecutor.java:93)
at info.magnolia.ui.api.action.AbstractActionExecutor.execute(AbstractActionExecutor.java:77)
at info.magnolia.ui.dialog.BaseDialogPresenter.executeAction(BaseDialogPresenter.java:189)
at info.magnolia.ui.dialog.BaseDialogPresenter$CommitDialogShortcutListener.handleAction(BaseDialogPresenter.java:271)
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <
[email protected]>
----------------------------------------------------------------
