[magnolia-dev] [JIRA] (MGNLUI-3266) DefaultImageProvider always assumes existence of image subnode

Tue, 18 Nov 2014 23:53:38 -0800

Issue Type: Bug Bug
Affects Versions: 5.3.5
Assignee: Unassigned
Components: image provider
Created: 19/Nov/14 8:47 AM
Description: 
    private Object getThumbnailResource(Node node, String workspace, String generator) {
        Object resource = null;
        try {
            Node imageNode = node.getNode(definition.getOriginalImageNodeName());



The image node is optional for most of custom types. Image provider assumes it always exists and attempts to retrieve the node without even checking for it's existence and as a result using try/catch block to steer execution flow. Furthermore this method does extensive checking for the mime type of underlying node w/o knowing how extending class might treat generation of thumbnails for given resource. This logic should either be removed and safety checks left to getGeneratorImagePath() method or exposed to extending classes for modification.
Project: Magnolia UI
Priority: Neutral Neutral
Reporter: Jan Haderka
Security Level: Public
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to