[magnolia-dev] [JIRA] (MGNLACTIVATION-99) Unpublishing right after publication can result in exception

[JIRA (on behalf of Jan Haderka)]

Jan Haderka reopened MGNLACTIVATION-99 Unpublishing right after publication can result in exception The code: When checking skipPath you check simply for startsWith. This is common mistake that will result in path that is superset of skipped path to be skipped as well, e.g. if skipPath=/skip/me it will skip also node at path /skip/meNOT The test: the TestSimpleSydicator is not really generic "testSS". More explicit name would help later to make anyone tempted to reuse it understand what it does. Something like ThrowExceptionWhileActivatingA_B_ANodeSyndicator since in your fix you are manipulating parent nodes of activated node, you need extra test to cover also the case when activating node just under the root (since root node that will be obtained as parent tends to behave differently in certain corner cases) test for names that are superset of failing name is called for (see above comment regarding code issue) Change By: Jan Haderka (10/Dec/14 9:20 AM) Resolution: Fixed Status: Resolved Reopened

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

---

----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------