[magnolia-dev] [JIRA] (MGNLUI-3380) App launcher layout reloading mechanism is broken and bogus

[JIRA (on behalf of Aleksandr Pchelintcev)]

Title: Message Title

Aleksandr Pchelintcev created an issue   Magnolia UI / MGNLUI-3380 App launcher layout reloading mechanism is broken and bogus Issue Type: Bug Affects Versions: 5.4 Assignee: Unassigned Components: applauncher Created: 18/Mar/15 12:44 PM Fix Versions: 5.4 Labels: platform-cell applauncher observation Priority: Major Reporter: Aleksandr Pchelintcev Security Level: Public There are several kinds of problems with App launcher layout dynamic reloading which lead to one consequence - the layout is not properly re-initialized upon changes. Things to check: Conceptually: the changes notification usually comes from a separate thread (observation) but the AppLayoutManager synchronously tries to update the layout relatively to the current user (there is/should be none!) In order to prevent the system eventbus listeners that handle the changes from leaking they are removed upon AppLauncher component detach (should only happen when the tab dies), but DeckLayout at times unnecessarily calls #remove(component) for AppLauncher (even though re-adding it in the same method) and the listener is wrongly removed. We should either ensure listener is re-attached or fix DeckLayout logic. Internally in AppDescriptorRegistry when determining what apps have changed, added or removed - we conduct quite a few operations with collections which involve comparison of AppDescriptors which do not have #equals()/#hashCode() methods overriden. Such logic might be fragile. Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) ---------------------------------------------------------------- Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com> ----------------------------------------------------------------