[magnolia-dev] [JIRA] (MGNLUI-3507) CKEDITOR-Plugin magnolialink has bad test for internal links

JIRA (on behalf of Adi De Masi) Tue, 28 Jul 2015 02:34:20 -0700

Title: Message Title

Adi De Masi created an issue

MGNLUI-3507

Issue Type:	Bug
Assignee:	Unassigned
Created:	28/Jul/15 11:28 AM
Priority:	Neutral
Reporter:	Adi De Masi
Security Level:	Public

Magnolialinks are inserted as ${link:{uuid:

{8cd...2f0}

,repository:

{website}

,path:

{/Home/path/to/page}

}}

We implemented a similar mechanism as the internal magnolia links in the ckeditor to handle links to special resources served by a servlet:

${mydocument:{type:

{SET}

,id:

{16513}

}}

This link is created with a custom plugin which works fine.

We now wanted to make these links editable by double-click on it (similar to magnolialink ). Problem is, that the original magnolialink -plugin catches the double-click and performs a check on the href-pattern:

 
                                                    (...)
// Double click
editor.on('doubleclick', function(ev) {
  var selected = CKEDITOR.plugins.link.getSelectedLink(editor);
  if (isInternalLink(selected)) {
     ev.data.dialog = null; // Eat the CK link dialog
     editor.getCommand(getWorkspace(selected)).exec(editor);
   }
});

(....)
function isInternalLink(element) {
        if (isLink(element) && element.getAttribute('href').substring(0,1) == '$') {
            return true;
        }

        return false;
    };

 
                                                

Because our custom link-pattern also matches this condition, the function 'isInternalLink' returns true and the click handler throws an error, because editor.getCommand(getWorkspace(selected)) will return undefined on our custom links. Because this raises an error, the double-click-handler in our custom plugin will never get fired.

Solution would be to improve the test for 'isInternalLink', e.g. like this:

 
                                                      function isInternalLink(element) {
      var needle = '${link';
      if (isLink(element) && element.getAttribute('href').indexOf(needle) === 0) {
          return true;
      }

      return false;
    };
 
                                                

or even to test it with a regex for the required pattern. This would make it more stable and help developers who want to extend the richt-text-editor

Add Comment

This message was sent by Atlassian JIRA

----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

[magnolia-dev] [JIRA] (MGNLUI-3507) CKEDITOR-Plugin magnolialink has bad test for internal links

Reply via email to