[magnolia-dev] [JIRA] (MGNLUI-4205) Setting "selected" is true in Select field doesn't work in case of existing item

[JIRA (on behalf of Oanh Thai Hoang)]

Title: Message Title

Oanh Thai Hoang created an issue   Magnolia UI / MGNLUI-4205 Setting "selected" is true in Select field doesn't work in case of existing item Issue Type: Bug Affects Versions: 5.4.12, 5.4.3 Assignee: Unassigned Attachments: Rename-contact.png, Select-field-configuration.png Created: 08/May/17 6:03 AM Priority: Neutral Reporter: Oanh Thai Hoang Step to reproduce: Import file to /modules/ui-framework/dialogs/rename/form/tabs/item/fields Open Contacts app Choose one item and select Rename contact Observation: Select field doesn't select Test 1 Expectation: Test 1 must be selected Source of problem Since code was introduced from MGNLUI-4113 public void setPropertyDataSourceAndDefaultValue(Property property) { this.field.setPropertyDataSource(property); if ((item instanceof ItemAdapter && ((ItemAdapter) item).isNew() && property.getValue() == null) || (!(item instanceof ItemAdapter) && property.getValue() == null)) { setPropertyDataSourceDefaultValue(property); } } so in case of item is existed like contact item, #setPropertyDataSourceDefaultValue will never call Suggestion We may introduce #setPropertyDataSourceAndDefaultValue again in SelectFieldFactory as below for case existing item: @Override public void setPropertyDataSourceAndDefaultValue(Property property) { super.setPropertyDataSourceAndDefaultValue(property); if ((item instanceof ItemAdapter && !((ItemAdapter) item).isNew() && property.getValue() == null)) { setPropertyDataSourceDefaultValue(property); } } Add Comment   This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf) ---------------------------------------------------------------- For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com> ----------------------------------------------------------------