#: Fabrizio Giustina changed the world a bit at a time by saying on  9/27/2005 
9:31 AM :#
You are right, I already saw that html "bug" when the patch that added
the style parameter was added...
anyway, I can't find a good reason why the simpleNavigationTag should
support writing a container tag at all... can't you simply do:
<div class="whatever">
  <cmsu:simpleNavigation startLevel="1" endLevel="1">
</div>

I would like to fix it in one of the following ways:
-1 deprecating the style attribute at all, planning to remove it in
future releases
-2 moving the class added by the parameter to the root ul (the output
will be  [ul class="level1 simple-nav"]. This could be a bit more
useful but the parameter name remains a bit misleading

Moving the discussion to the developer list for feedback from other developers.

fabrizio



My 2ec on this:

1/ I would let style attribute exist: but make it coherent with HTML style attribute. If specified than it should be output. Also add class attribute. (the more we allow customization the better :-) ).

2/ considering that there is no option to both customize the container DIV and the UL, I tend to agree with you that simpleNavigation should output only the UL. The user will be required to place it in whatever container he likes and with the style/class he likes.
The attributes style and class should be copied to the enclosing UL.

With these 2 a user will be able to do whatever styling he needs on all levels.

thanks,

./alex
--
.the_mindstorm.


On 9/27/05, Eric Everman <[email protected]> wrote:
Hi-

I am using the simpleNavigation tag like this:

<cmsu:simpleNavigation startLevel="1" endLevel="1" style="simple-nav" />

and it results is this HTML (with angle braces turned to square
braces to prevent email mess-ups):

[span class="simple-nav"]
     [ul class="level1"]
         [li class="leaf"][a href="/author/Home/About.html">Child
Page </a></li><li class="leaf"><a href="/author/Home/Birds.html"]
Birds of a Feath[/a][/li]
         ...
         [/ul]
[/span]

Its that [span] tag that is the problem:  A UL tag cannot be nested
in a SPAN tag - thats not valid html.  Could that be updated to
output a [div] tag instead?  Also, that 'style' name is a bit
misleading - how about 'class' or 'class-attrib' instead?

Thanks Again,

Eric Everman

----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------


----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------


----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------

Reply via email to