Thanks a lot for the feedback. My comments are inline.
#: Philipp Bracher changed the world a bit at a time by saying on 10/12/2005
10:50 AM :#
Unfortunately, as I already talked with Philipp the solution required
a lot of code on controls side, and even if I did my best I couldn't
found a 100% pure solution (there is a small hack I had to do :-S).
If it looks oke with you I can start on adding functionality to it,
meaning to plug DWR in. While from a lot of features this should be
simple there are 2 aspects that I would like to check with you:
Here is some unordered intput perhaps you like the one or the other:
- A green, red light would be nice (so that you see the current state)
- this light could be on the outer most right of the main bar
- it could be an Funcitons button ( a gearwheel icon could do the job)
instead of an Activation button
- Should it be placed after the Properties button?
- Would be greate if one could define additional functions in the tag
<mainBar ..>
<mainBarFunction name="" label="" function="someJSFunction()" />
</mainBar>
1/ the new control is able to be configured to display an icon, so I can do this
2/ I thought of this too, but I considered it fits better on the other side :-s.
3/ this is completely different and will require lots of refactoring. And I am not sure we want to
do this before moving along to another solution ;-).
1/ authorization: currently when activating the request passes through
the SecurityFilter which I suppose is responsible for checking if the
action is to be granted or not. Considering that the SecurityFilter
uses the mapping /*, I suppose that the DWR request will be pass also
through it. Is anything else that must be checked?
The filter is responsible for the login and url based authorization
checking. The security in the repository is done in the AccessManager
If you use: SessionAccessControl.getRepository() every action is
checked.
Yeah, you are right. I felt like I was missing something.
2/ error reporting: what happens in a case of a failure? or a timeout?
(I don't think it is possible to define a timeout, considering that
the activation may take an indeterminate time). Is it enough just to
inform the user that the activation failed? (and probably provide some
additional infos about this failure).
I have done this for the admin interface (configure a false subscriber
and test it). For the current trunk this is ok. Later it would be nice
to have a formated magnolia like alert dialog, but this for the future.
I will take a look.
Please comment on the aboves and feel free to move this to DEV ML as I
already know that you prefer to have these discussions happening there
(my bad habbits are still keeping me from posting internal development
questions on ML, but I am working on this ;-) ).
I do so.
Philipp Bracher
./alex
--
.w( the_mindstorm )p.
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------
