Hi all,
sorry for jumping in to it, but couldn't resist :D
I had a quick look at JCRExpressionStore and I agree there are many
places we could improve
few questions tough:
1. in JCRExpressionStore.storeExpression(FlowExpression fe)
why are we creating a node with the ID and again setting a property
with the same ID (parseable String)
wouldn't be possible to simply create a node with this ID (as you are
doing at the moment) and in findExpression(FlowExpressionId fei)
instead of going through all Expressions or using search, simply
getNode(ID) ?
I've had a look at Content.Iterator(), in fact it's rather
Content.getChildren(xxx).iterator() which (getChildren()) returns a
new list/set of Content. We would certainly gain time by directly
calling the JCR's Node.nodeIterator()...
true, if you know in this hierarchy all nodes are of type
"Expression" then simply getNodes() instead of getChildren(filter)
OR as you already said simply use query "select * from expression"
Regards,
- Sameer
On May 19, 2006, at 10:41 AM, John Mettraux wrote:
Hi all,
On 5/19/06, Nicolas <[email protected]> wrote:
Hey John,
wow - 10 minutes indeed :D real fast. What was the train you were
riding?
Since I have made a hierarchy for storing the expressions, where
should I position myself when calling Content.iterator() ... which
expressions do you expect to handle within the method
contentIterator ?
Indeed, there is a potential optimization here.
In the default OpenWFE FileExpressionStore, I used to simply look at
the name of the file containing the expresssion. As this name contains
the name of the expression, it was easy to say : this expression
[name] belongs to the expressions the contentIterator is in charge to
iterate through, lets take it.
I think that for an initial (today) re-implementation we can go
without that optimization and leave it for tomorrow (japanese time).
I've had a look at Content.Iterator(), in fact it's rather
Content.getChildren(xxx).iterator() which (getChildren()) returns a
new list/set of Content. We would certainly gain time by directly
calling the JCR's Node.nodeIterator()...
What do you guys think ?
--
John Mettraux -///- http://jmettraux.openwfe.org
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------
