[ http://jira.magnolia.info/browse/MAGNOLIA-899?page=comments#action_12012 
] 

Fabrizio Giustina commented on MAGNOLIA-899:
--------------------------------------------

well, these properties should definitively be stored in magnolia jars... by 
using Spring these beans would probably be defined in a set of xml files, each 
stored in the appropriate module, and loaded from the classpath.
At the moment I think that the easiest solution is to move them to a property 
file in magnolia-core and to load it from the classpath (merging its content 
with System Properties): it's not a great solution since there are 
implementation classes that doesn't belong to core but I think that it's pretty 
useless at this point to spend time in splitting them to different properties 
files and to implement a way to load them from each module (that comes for free 
with Spring).
If we add the properties file to the classpath anybody is still free to define 
its own implementation by adding a different file to WEB-INF/classes, since the 
classloader give priority to files in the webapp folder.

> move away implementation classes definition from magnolia.properties
> --------------------------------------------------------------------
>
>          Key: MAGNOLIA-899
>          URL: http://jira.magnolia.info/browse/MAGNOLIA-899
>      Project: magnolia
>         Type: Task

>   Components: core
>     Versions: 3.0 Beta 1
>     Reporter: Fabrizio Giustina
>     Assignee: Boris Kraft
>      Fix For: 3.0 RC1

>
>
> magnolia.properties in WEB-INF/config/* was meant to host configuration that 
> need to be modified by users and that can change on different environment 
> (e.g. repository configuration, logging).
> Definition of magnolia internal components should be moved away from here, 
> because it's not intended to be modified by end users (well, not usually), 
> and because having it here forces users to change the file at every upgrade 
> (I had my instance broken several times while using 3.0 snapshot due to 
> changes in implementation classes because that file needed to be updated)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------

Reply via email to