[ http://jira.magnolia.info/browse/MAGNOLIA-921?page=comments#action_12055 ]
Boris Kraft commented on MAGNOLIA-921: -------------------------------------- IIRC the original logic meant that external links will be opened in a new window wheras internal links are not. With your patch all links will be opened in external windows, right? Thats not what we want ;-) > samples/paragraphs/link.jsp index of :// is incorrect > ----------------------------------------------------- > > Key: MAGNOLIA-921 > URL: http://jira.magnolia.info/browse/MAGNOLIA-921 > Project: magnolia > Type: Bug > Components: samples > Versions: 2.1.5 > Reporter: James Reynolds > Assignee: Boris Kraft > Priority: Minor > > Original Estimate: 2 minutes > Remaining: 2 minutes > > This: > if (html.indexOf("://")==-1) > html.append("http://"+link+"\"; target=\"_blank\">"); > Should be: > if (link.indexOf("://")==-1) > html.append("http://"+link+"\"; target=\"_blank\">"); > else html.append(link+"\" target=\"_blank\">"); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://www.magnolia.info/en/magnolia/developer.html ----------------------------------------------------------------
