[ http://jira.magnolia.info/browse/MAGNOLIA-925?page=comments#action_12190 ] Philipp Bracher commented on MAGNOLIA-925: ------------------------------------------
Fabrizios instructions how to proceed: This is what should be done: - implement a FilterManager which holds all the filter definitions loaded from jcr (like TemplateManager or other similar classes) - add an hook that loads filters for each module (just like it's done now fo templates, pages...). Better if filter definitions are also allowed on the "server" path and not only for modules since some of them are very core (this is something we should think about also for other things, like virtual uri mappings) - Create a FilterDefinition class that should contains: filter class, optional parameters and *important* filter priority (I planned to use numbers like 100,200,300,... for actual filters, so that you can always insert a need filter in between). FilterDefinitions should automatically be sorted by priority, FilterManager should log a warn if more than one filter define the same priority. - add filter configurations to bootstrap xml for each module - modify MagnoliaManagedFilter removing hardcoded filters and calling filter manager to obtain a sorted list of filters to apply > Filter configuration in config repository > ----------------------------------------- > > Key: MAGNOLIA-925 > URL: http://jira.magnolia.info/browse/MAGNOLIA-925 > Project: magnolia > Issue Type: Improvement > Components: core > Affects Versions: 3.0 Beta 1 > Reporter: Fabrizio Giustina > Assigned To: Boris Kraft > Priority: Minor > Fix For: 3.0 Final > > > Complete the work on info.magnolia.cms.filters.MagnoliaManagedFilter: > - make filter and filter parameters configurable from the magnolia repository > instead of adding them to web.xml (filter name, class, priority, parameters) > This could allow modules to add filters at runtime, without any need for > modifying web.xml, and changing parameters without a restart (for example, > login configuration) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://www.magnolia.info/en/magnolia/developer.html ----------------------------------------------------------------
