It's tortoise. I'll have to see if I can get it to create a genuine diff
the next time.
Glad I could help.
-- David
Philipp Bracher (JIRA) wrote:
[ http://jira.magnolia.info/browse/MAGNOLIA-1041?page=all ]
Philipp Bracher resolved MAGNOLIA-1041.
---------------------------------------
Fix Version/s: 3.0 RC3
Resolution: Fixed
Assignee: Philipp Bracher (was: Boris Kraft)
Thanks: applied.
Remark: your patches are always a complete replacement of the code and not
replacing only few lines (as it is normal for patches). Not sure if it is your
tortoise client or we have to set the property svn:eol-style on svn to native
everywhere.
ContentNodeIterator in 3.0 doesn't properly nest node collections + loses
localContentNode
------------------------------------------------------------------------------------------
Key: MAGNOLIA-1041
URL: http://jira.magnolia.info/browse/MAGNOLIA-1041
Project: magnolia
Issue Type: Bug
Components: taglibs
Affects Versions: 3.0 RC3
Environment: NA
Reporter: David Smith
Assigned To: Philipp Bracher
Fix For: 3.0 RC3
Attachments: ContentNodeIteratorFix.patch
Original Estimate: 10 minutes
Remaining Estimate: 10 minutes
savePrevState doesn't always run because of possible exceptions just before
savePrevState() is called, but restorePrevState _always_ does. Need to
introduce a flag so restorePrevState() only executes if savePrevState() does.
Net effect: localContentNode can end up being null, breaking the ability of
NewBar to properly create nested paragraphs.
--
David Smith
Network Operations Supervisor
Department of Entomology
Cornell University
2132 Comstock Hall
Ithaca, NY 14853
Phone: (607) 255-9571
Fax: (607) 255-0940
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------