[ http://jira.magnolia.info/browse/MAGNOLIA-1119?page=comments#action_13232 ] Chris Miner commented on MAGNOLIA-1119: ---------------------------------------
well yes from the logic of it all one could stop once any non empty value was found. I think the intention is to find out if *all* the values of getValues() are empty. Stopping with just one empty value wouldn't be the same thing. But then I wondered if there was some logic to putting the empty values in the list returned from getValues() in the first place. Maybe the right fix it to not add them to the list returned by getValues() in the first place? Unless an empty value in that context has a semantic meaning such as 'delete this property'. In which case you would want to differenciate between an empty value and no value. > Required field in dialog > ------------------------ > > Key: MAGNOLIA-1119 > URL: http://jira.magnolia.info/browse/MAGNOLIA-1119 > Project: Magnolia > Issue Type: Bug > Affects Versions: 3.0 RC2 > Environment: OS: windows XP Pro, Tomcat 5.0, java j2sdk1.4.2_12 > Reporter: CAPITAINE Harold > Assigned To: Philipp Bracher > Fix For: 3.0.x > > Attachments: DialogControlImpl.patch, DialogControlImpl.patch > > > When putting a field in a dialog to required, the field still can be empty. > Problem should come from DialogControlImpl.java in the validate function. > More precisely in the second part of the test. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://www.magnolia.info/en/magnolia/developer.html ----------------------------------------------------------------
