Jira is MAGNOLIA-1345 (for both commits, it's the same issue), the
explanation is the same as in the code comments thought ;)
It's not silently ignored, it's logged twice in the log. Throwing an
error will make the bootstrap process stop, so it's not an option.

fabrizio


On 2/6/07, GrĂ©gory Joseph <[email protected]> wrote:
Same remark about Jira ;)

+ I don't think we should allow this by simply ignoring it. I think
it should be an error. (i.e. avoid a meaningless NPE is ok, but
silently hiding it isn't imho)

Cheers

g


On 06 Feb 2007, at 23:41, [EMAIL PROTECTED] wrote:

> Revision8362AuthorfgiustDate2007-02-06 23:41:47 +0100 (Tue, 06 Feb
> 2007)Log Messagefix another NPE when trying to import content into
> a non existing repositoryModified Paths
> magnolia/trunk/magnolia-core/src/main/java/info/magnolia/cms/core/
> ie/DataTransporter.java
> Diff
> Modified: magnolia/trunk/magnolia-core/src/main/java/info/magnolia/
> cms/core/ie/DataTransporter.java (8361 => 8362)--- magnolia/trunk/
> magnolia-core/src/main/java/info/magnolia/cms/core/ie/
> DataTransporter.java  2007-02-06 22:34:25 UTC (rev 8361) +++
> magnolia/trunk/magnolia-core/src/main/java/info/magnolia/cms/core/
> ie/DataTransporter.java       2007-02-06 22:41:47 UTC (rev 8362)@@ -198,6
> +198,13 @@             throws IOException
> {          HierarchyManager hm = MgnlContext.getHierarchyManager
> (repositoryName);+        if (hm == null) { +            // this
> happens when the samples module tries to insert content into the
> dms repository and dms is not +            // installed
> +            log.warn("NOT importing content from: [{}] since
> repository [{}] does not exist", //$NON-NLS-1$ +                new
> Object[]{name, repositoryName}); +            return;
> +        }         Workspace ws = hm.getWorkspace();          if
> (log.isDebugEnabled()) {
>


----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------


----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------

Reply via email to