On Feb 7, 2007, at 08:52 , Fabrizio Giustina wrote:
Jira is MAGNOLIA-1345 (for both commits, it's the same issue), the
explanation is the same as in the code comments thought ;)
Ok. So imho, the real issue is that the sample modules has dms
samples. They should probably be separated.
Anyway, don't you think a module should not be able to start if it
tries to bootstrap data in a non-existing repository, because it
simply means something is *wrong* ? If the sample module is wrong
(and it is), heck, let's fix it instead of working around its flaws.
Besides, the samples module has a dependency on the dms module (a
magnolia-module dependency, in the module xml definition that is), so
it should not be registered if the dms module is not present in your
magnolia. If it is actually registered, then THERE is the bug...
could you check ?
Maybe you have another use case that would be more convincing where
bootstrapping should not stop with a wrong module ? ;)
It's not silently ignored, it's logged twice in the log.
Maybe that's just me, but I feel this is in reality equivalent. How
many of your customers are actually looking and checking the logs to
see if everything is ok at all times ?
Throwing an error will make the bootstrap process stop, so it's not
an option.
Why? Cfr my first remark. If the system is wrongly setup, I think it
should not start.
I'll reopen the issue so we can discuss it; hope that's ok :)
Cheers,
greg
On 2/6/07, Grégory Joseph <[email protected]> wrote:
Same remark about Jira ;)
+ I don't think we should allow this by simply ignoring it. I think
it should be an error. (i.e. avoid a meaningless NPE is ok, but
silently hiding it isn't imho)
Cheers
g
On 06 Feb 2007, at 23:41, [EMAIL PROTECTED] wrote:
> Revision8362AuthorfgiustDate2007-02-06 23:41:47 +0100 (Tue, 06 Feb
> 2007)Log Messagefix another NPE when trying to import content into
> a non existing repositoryModified Paths
> magnolia/trunk/magnolia-core/src/main/java/info/magnolia/cms/core/
> ie/DataTransporter.java
> Diff
> Modified: magnolia/trunk/magnolia-core/src/main/java/info/magnolia/
> cms/core/ie/DataTransporter.java (8361 => 8362)--- magnolia/trunk/
> magnolia-core/src/main/java/info/magnolia/cms/core/ie/
> DataTransporter.java 2007-02-06 22:34:25 UTC (rev 8361) +++
> magnolia/trunk/magnolia-core/src/main/java/info/magnolia/cms/core/
> ie/DataTransporter.java 2007-02-06 22:41:47 UTC (rev 8362)
@@ -198,6
> +198,13 @@ throws IOException
> { HierarchyManager hm = MgnlContext.getHierarchyManager
> (repositoryName);+ if (hm == null) { + // this
> happens when the samples module tries to insert content into the
> dms repository and dms is not + // installed
> + log.warn("NOT importing content from: [{}] since
> repository [{}] does not exist", //$NON-NLS-1$ + new
> Object[]{name, repositoryName}); + return;
> + } Workspace ws = hm.getWorkspace(); if
> (log.isDebugEnabled()) {
>
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------
