Hi,

Okay, I changed it and the admin ui works just fine.  

http://jira.magnolia.info/browse/MAGNOLIA-1351

In doing the change, I did change the sematics slightly, but in practice I 
don't think this matters.  The old code used everything between '/pages/'
and the last '.' as the page name.  Suggesting that 'some/page/name'
would be a valid page name.  Not sure if that was intended or not.  Not sure
if one can really use such page names.  So... the new semantic is to just use 
the very last part of the path.  Instead of 'some/page/name' just 'name'

Chris

Am Donnerstag, 8. Februar 2007 10:34 schrieb Philipp Bracher:
> It looks like a bug, but there was an original intention I can't
> remember exactly, but it was in the domain of the  virtual uri
> mappping. Can be that this was only an issue in 2.1 and this is now
> solved.
>
> If you change it and all the admin interface pages are working fine
> (tools, dms, ..) I think it does not make sense to keep this anymore.
>
> Let look at it as a bug.
>
> Philpp Bracher
>
> On 07.02.2007, at 13:15, Chris Miner wrote:
> > I think this may be a bug, and wanted a second opinion.  I seems to
> > me that if
> > a request has been forwarded to an url which is serviced by the
> > PageMVCServlet, it should determine the handling page name from the
> > uri the
> > request was forwarded to and not from the uri that did the forwarding.
> >
> > Currently it looks at:
> >  request.getAttribute("javax.servlet.include.servlet_path")
> >  request.getAttribute("javax.servlet.forward.servlet_path")
> >
> > before trying:
> >  request.getRequestURI()
> >
> > This means in the case of forwarding and includes, it will try to
> > determine a
> > page handler from the url that is doing the forwarding.  This is
> > probably not
> > what is intended.
> >
> > Opinions?
> >
> > ----------------------------------------------------------------
> > for list details see
> > http://www.magnolia.info/en/magnolia/developer.html
> > ----------------------------------------------------------------
>
> ----------------------------------------------------------------
> for list details see
> http://www.magnolia.info/en/magnolia/developer.html
> ----------------------------------------------------------------

----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/magnolia/developer.html
----------------------------------------------------------------

Reply via email to