[ http://jira.magnolia.info/browse/MAGNOLIA-523?page=comments#action_13672 ] eriko vanderten commented on MAGNOLIA-523: ------------------------------------------
http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/4/gohan202.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/5/gohan203.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/6/gohan204.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/7/gohan205.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/8/gohan206.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/9/gohan207.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/10/gohan208.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/11/gohan209.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/12/gohan210.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/13/gohan211.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/14/gohan212.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/15/gohan213.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/16/gohan214.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/17/gohan215.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/18/gohan216.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/19/gohan217.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/20/gohan218.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/21/gohan219.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/22/gohan220.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/23/gohan221.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/24/gohan222.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/25/gohan223.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/26/gohan224.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/27/gohan225.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/28/gohan226.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/29/gohan227.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/30/gohan228.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/31/gohan229.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/32/gohan230.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/33/gohan231.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/34/gohan232.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/35/gohan233.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/36/gohan234.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/37/gohan235.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/38/gohan236.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/39/gohan237.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/40/gohan238.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/41/gohan239.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/42/gohan240.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/43/gohan241.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/44/gohan242.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/45/gohan243.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/46/gohan244.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/47/gohan245.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/48/gohan246.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/49/gohan247.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/50/gohan248.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/51/gohan249.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/52/gohan250.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/53/gohan251.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/54/gohan252.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/55/gohan253.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/56/gohan254.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/57/gohan255.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/58/gohan256.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/59/gohan257.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/60/gohan258.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/61/gohan259.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/62/gohan260.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/63/gohan261.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/64/gohan262.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/65/gohan263.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/66/gohan264.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/67/gohan265.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/68/gohan266.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/69/gohan267.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/70/gohan268.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/71/gohan269.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/72/gohan270.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/73/gohan271.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/74/gohan272.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/75/gohan273.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/76/gohan274.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/77/gohan275.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/78/gohan276.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/79/gohan277.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/80/gohan278.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/81/gohan279.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/82/gohan280.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/83/gohan281.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/84/gohan282.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/85/gohan283.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/86/gohan284.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/87/gohan285.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/88/gohan286.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/89/gohan287.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/90/gohan288.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/91/gohan289.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/92/gohan290.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/93/gohan291.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/94/gohan292.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/95/gohan293.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/96/gohan294.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/97/gohan295.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/98/gohan296.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/99/gohan297.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/100/gohan298.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/101/gohan299.html - http://gforge.casil.ucdavis.edu/tracker/download.php/52/350127/200118/102/gohan300.html > SimpleNavigationTag showing empty <ul> when no visible children > --------------------------------------------------------------- > > Key: MAGNOLIA-523 > URL: http://jira.magnolia.info/browse/MAGNOLIA-523 > Project: Magnolia > Issue Type: Bug > Components: taglibs > Affects Versions: 2.1 Final > Reporter: John Olival > Assigned To: Philipp Bracher > Priority: Minor > Fix For: 3.0.x > > > When displaying the navigation for elements that have children and if all the > elements' children are set to hideInNav, an empty ul: <ul > class="levelx"></ul> is shown. In CSS drop-down navigation menus, this > displays as an empty block, but also it is syntactically incorrect HTML. This > is only a problem for elements which are located anywhere in the branch of a > selected element. E.g. In the tree > Home > + Section 1 > ... > + Section 2 > + Subsection 2.1 > + Subsection 2.2 > + Page 2.2.1 > + Page 2.2.2 > + Page 2.2.3 > + Subsection 2.3 > + Page 2.3.1 > + Page 2.3.2 > + Page 2.3.3 > ... > Pages under 2.2 are marked as hideInNav; if Page 2.2.1 is selected so is the > currently active page, then an empty ul element is created. > Having looked at the code, I reckon the fix is here (line 249): > if (activePage.getHandle().equals(child.getHandle())) { > // self > // check if child has visible children > if (hasVisibleChildren(child)) { > showChildren = true; > } > self = true; > cssClasses.add("active"); //$NON-NLS-1$ > } > It hasn't been tested. > John -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://www.magnolia.info/en/developer.html ----------------------------------------------------------------
