[ http://jira.magnolia.info/browse/MAGNOLIA-316?page=all ]

Sameer Charles updated MAGNOLIA-316:
------------------------------------

        Fix Version/s: 3.1
    Affects Version/s: 3.0.2

> HierarchyManager can become immutable with respect to most of its fields.
> -------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-316
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-316
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 2.1 Final, 3.0.2
>         Environment: n/a
>            Reporter: David Bullock
>         Assigned To: Sameer Charles
>            Priority: Minor
>             Fix For: 3.1
>
>
> HierarchyManager exposes the following mutator methods:
> - void setStartPage(Node)  [unused!]
> - void init(Node)
> - void init(Node, AccessManager)
> - void setAccessManager(AccessManager)
> In all cases where these methods are used, they are used:
>   a) ONCE only, and 
>   b) on a HierarchyManager instance which is assigned to a local variable in 
> the same method
> It would better reflect the manner in which HierarchyManager is used if the 
> fields 'startPage', 'workspace', and 'accessManager' were set only via the 
> constructor, and the mutator methods removed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------

Reply via email to