On May 3, 2007, at 09:24 , Philipp Bracher wrote:
I don't think that using jcr order here is a good idea, the reason
for
having a custome property was also for allowing to easy add custom
filters in bootstrap. Now this can't be done anymore since you will
have to:
Same is true for the menu configuration or other centralized
configuration. Is having a priority/order value really so much
better? Who guaranties the original values of these. What is if you
run out in between values, ....
+1, i find it always awkward to have to guess the values of the other
filters out of the blue.
- write some custom code that reorder filters after bootstrap (just
like you did from cache, and could be ok for standard modules, but I
don't think it's a viable solution for users that simply need to
add a
custom filters)
We are talking about on single line of code (or two to be honest ;-)
And ideally as from 3.1, this kind of code will be in the "update
code", not in the Module class itself anymore.
the inability to order nodes during bootstrap (like we did in the
past
with our custom order property) is generally annoying, but in this
case it totally breaks the feature, since unsorted filters are
useless...
I have several cases where I needed to add filters other than the
standard magnolia ones, and I am pretty worried that now I will
not be
able to do as easily as I did till now using that "priority"
attribute...
It seems to me that it could hardly be simpler than ordering your
filters in the tree. If you don't have a "real" jar module for your
project, you can still fake one directly in the webapp and register
the module/update code from there.
If the filters were spread and configured from config/modules, then
obviously the priority setting would be needed, but that's not the
case. And if it were, we'd need at the very least an extra page to
summarize the list/configuration/order of the filters, which is pbly
be out of scope at least for 3.1
g
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------
