[ http://jira.magnolia.info/browse/MAGNOLIA-1523?page=comments#action_13989 
] 
            
Grégory Joseph commented on MAGNOLIA-1523:
------------------------------------------

Done - 
New class is called AggregationState and lazily instanciated by the WebContext.
Aggregator is still there, should still work, but is completely deprecated.

One can now do MgnlContext.getAggregationState().getXYZ()

Also deprecated a bunch of methods in Path.
The Resource class now uses AggregationState.

Todo : 
* the original Aggregator.getExtension code was getting the extension from the 
*current* URI, and if that was empty, was getting it from the original URI. Now 
AggregationState.getExtension() only returns what's been set by the 
ContentTypeFilter. Quid ?
* RepositoryMappingFilter is resetting the extension, but that seems useless - 
especially if the above is corrected to behave like Aggregator did.
* other classes to review, still using the now deprecated code: 
BasePatternVoter, CacheKey, UUIDRequestDispatcher, ZipUpload

> Aggregator can become a simple bean and be exposed in the context
> -----------------------------------------------------------------
>
>                 Key: MAGNOLIA-1523
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-1523
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: core
>            Reporter: Grégory Joseph
>         Assigned To: Grégory Joseph
>             Fix For: 3.1 M2
>
>
> The Aggregator class is currently just a bunch of get/set static methods that 
> delegate to get/setAttribute of MgnlContext. Instead, we could make this 
> class a simple javabean, and expose one instance of it in the (Web)Context

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------

Reply via email to