[ http://jira.magnolia.info/browse/MAGNOLIA-1512?page=comments#action_14039 
] 
            
Grégory Joseph commented on MAGNOLIA-1512:
------------------------------------------

It is forced, in a sense, now: the request's char.encoding is going to depend 
on the requested'uri extension/mimetype.
It is not set by ContentFilter *only* if it is already set (by another 3rd 
party filter or by the container for instance).
It wouldn't make sense to not set it at all (tomcat would use iso-8850-1) since 
we set it to serve the magnolia pages. (thus the form data is encoded by the 
browser in that page's response encoding)

> Request charset should be set before any req.getParameter call
> --------------------------------------------------------------
>
>                 Key: MAGNOLIA-1512
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-1512
>             Project: Magnolia
>          Issue Type: New Feature
>          Components: core
>            Reporter: Grégory Joseph
>         Assigned To: Grégory Joseph
>             Fix For: 3.1 M2
>
>
> At the moment, the request charset is set using Aggregator.getExtension(), 
> which in turns uses Context.getAttribute. Since the WebContextImpl 
> implementation of getAttribute calls getParameter in case the attribute does 
> not exist on the request, thus making the setCharacterSet call useless - and 
> preventing parameters to be parsed properly (indeed, the container will parse 
> them on the first call to getParam*() with a default encoding - iso-8859-1 in 
> the case of tomcat) 
> We might solve this by making the Aggregator.getExtension method (and 
> associated) just using the context attribute - which have to be set 
> previously, for instance by a new filter that has yet to be created.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------

Reply via email to