[ http://jira.magnolia.info/browse/MGNLXLS-8?page=all ]
Grégory Joseph updated MGNLXLS-8:
---------------------------------
Description:
I couldnt' manage to put the pre-rendering logic in a SaveHandler, mostly
because it doesn't have a "postSave" hook. Using the one from the dialog could
have worked - if there'd be a clean way to get the "save node".
Also, this introduced a dependecy on HierarchyManager, which would break 3.0 /
3.1 compatibility since the HierarchyManager changed package. *
Instead now, the logic is called by the excel.jsp, which is similar but less
elegant than having this in a ParagraphRenderer.
The SaveHandler still exists, but only removes the "pre-rendered" property if
it had been previously created.
Let's review this.
* since we will also move the NodeData and Content classes to interfaces in the
api package, breakage will happen anyway. I guess we'll need to do parallel
releases.
was:
I couldnt' manage to put the pre-rendering logic in a SaveHandler, mostly
because it doesn't have a "postSave" hook. Using the one from the dialog could
have worked - if there'd be a clean way to get the "save node".
Instead now, the logic is called by the excel.jsp, which is similar but less
elegant than having this in a ParagraphRenderer.
The SaveHandler still exists, but only removes the "pre-rendered" property if
it had been previously created.
Let's review this.
> SaveHandler or ParagraphRenderer
> --------------------------------
>
> Key: MGNLXLS-8
> URL: http://jira.magnolia.info/browse/MGNLXLS-8
> Project: Magnolia Excel Renderer Module
> Issue Type: Task
> Reporter: Grégory Joseph
> Assigned To: Philipp Bracher
> Fix For: 1.0
>
>
> I couldnt' manage to put the pre-rendering logic in a SaveHandler, mostly
> because it doesn't have a "postSave" hook. Using the one from the dialog
> could have worked - if there'd be a clean way to get the "save node".
> Also, this introduced a dependecy on HierarchyManager, which would break 3.0
> / 3.1 compatibility since the HierarchyManager changed package. *
> Instead now, the logic is called by the excel.jsp, which is similar but less
> elegant than having this in a ParagraphRenderer.
> The SaveHandler still exists, but only removes the "pre-rendered" property if
> it had been previously created.
> Let's review this.
> * since we will also move the NodeData and Content classes to interfaces in
> the api package, breakage will happen anyway. I guess we'll need to do
> parallel releases.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------
