[ http://jira.magnolia.info/browse/MAGNOLIA-1417?page=all ]
Philipp Bracher resolved MAGNOLIA-1417.
---------------------------------------
Fix Version/s: 3.0.3
3.1 M2
(was: 3.0.x)
Resolution: Fixed
Assignee: Philipp Bracher (was: Boris Kraft)
I fixed it in a simple way:
- required field works
- binaries are checked
- alert is showed (only the first invalid field)
- you have to select the binaries again
- tab is not switched
- label is not red
Means it is working, but we need a better solution. This will be part of the
dialog refactoring.
> Failed dialog validation should not save/close the dialog
> ---------------------------------------------------------
>
> Key: MAGNOLIA-1417
> URL: http://jira.magnolia.info/browse/MAGNOLIA-1417
> Project: Magnolia
> Issue Type: Bug
> Components: gui
> Affects Versions: 3.0.1
> Reporter: Grégory Joseph
> Assigned To: Philipp Bracher
> Fix For: 3.0.3, 3.1 M2
>
> Attachments: MAGNOLIA-1417.patch
>
>
> Currently, dialog controls marked as required can still be empty.
> Patches have been provided by MAGNOLIA-1119 and MAGNOLIA-1361 and are
> summarized/improved in the attached patch.
> One of the problems with these patches is that the validation code was called
> during rendering: as a result mandatory fields were immediately marked "red",
> and the user did not have any indication of what was wrong anymore after a
> failed validation, since nothing changed visually. It also removed the alert
> box, which while not being the most sexy device was a way of saying to the
> user that something was wrong. (if the missing required field was in another
> tab, the user would just see nothing)
> To fix this, I introduced the "wasValidatedOrNotSaved" field in
> DialogControlImpl.
> Another problem is that a file control would loose its file upon failed
> validation and the user would thus have to reselect and reupload it. while
> that's viable with simple dialogs, it is not in more complex scenarios where
> multiple files are involved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------
