[ http://jira.magnolia.info/browse/MAGNOLIA-1566?page=all ]
Sameer Charles resolved MAGNOLIA-1566.
--------------------------------------
Resolution: Fixed
Fixed:
Basic FormClientCallback sets login error on failed login which is passed as a
map to freemarker template.
You can override FormClientCallback.getMessages(HttpServletRequest request) to
extend/change this behaviour.
> Expose login failed attribute to form pages
> -------------------------------------------
>
> Key: MAGNOLIA-1566
> URL: http://jira.magnolia.info/browse/MAGNOLIA-1566
> Project: Magnolia
> Issue Type: Improvement
> Components: security
> Environment: 3.1-SNAPSHOT
> JBoss 4.0.5
> Reporter: Amir Mistric
> Assigned To: Sameer Charles
>
> Since FormClientCallback does not put mgnlLoginError request attribute into
> Freemarker data model one cannot "capture" such attribute and display error
> message to the user when login fails on Form based authentication.
> Further investigation shows that this would not be possible since base
> interface does not expose request object (only response is available) so
> options are:
> 1. use 401 error page (this did not work even as I declared a simple html 401
> page)
> 2. expose request in base interface and abstract class and then in
> FormClientCallback grab the mgnlLoginError if set and put it into freemarker
> data set (hash map)
> 3. expose request object in every freemarker call (just like contextPath is
> exposed, if request is exposed contextPath can be ommited actually...) (see
> FreemarkerHelper.render)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------