As minor as it may be, this is a bugfix that should ideally appear on the change log, i.e in jira. (and while we're at it we should make sure this behaviour is consistent with other tags)

thx

g

On Oct 31, 2007, at 08:45 , [EMAIL PROTECTED] wrote:

Revision12113AuthorfgiustDate2007-10-31 08:45:50 +0100 (Wed, 31 Oct 2007)Log Messageminor fix: don't consider empty width and heigth attributes as setModified Paths magnolia/trunk/magnolia-taglib-utility/src/main/java/info/magnolia/ cms/taglibs/util/ImgTag.java
Diff
Modified: magnolia/trunk/magnolia-taglib-utility/src/main/java/info/ magnolia/cms/taglibs/util/ImgTag.java (12112 => 12113)--- magnolia/ trunk/magnolia-taglib-utility/src/main/java/info/magnolia/cms/ taglibs/util/ImgTag.java 2007-10-31 01:02:12 UTC (rev 12112) +++ magnolia/trunk/magnolia-taglib-utility/src/main/java/info/magnolia/ cms/taglibs/util/ImgTag.java 2007-10-31 07:45:50 UTC (rev 12113)@@ -136,7 +136,8 @@ Map attributes = new HashMap (htmlAttributes); attributes.put("title", alt); - if (!attributes.containsKey("width") && !attributes.containsKey ("height")) {+ if (StringUtils.isBlank((String) attributes.get("width")) + || StringUtils.isBlank ((String) attributes.get("height"))) { String width = props.getProperty(FileProperties.PROPERTY_WIDTH); if (StringUtils.isNotEmpty(width)) { attributes.put ("width", width);@@ -163,6 +164,7 @@ out.write (request.getContextPath()); out.write (imgSrc); out.write("\"/>");+ out.write("<param name=\"wmode\" value=\"transparent\"/ >"); out.write("</object>"); }



----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------

Reply via email to