[ http://jira.magnolia.info/browse/MAGNOLIA-540?page=comments#action_14959 ] Fabrizio Giustina commented on MAGNOLIA-540: --------------------------------------------
> The problem is that with the commons-upload-based implementation, request > parameters are lost. mh, not sure if mixing query string with a multipart form parameters could be a standard behavior, but if request.getParameter() actually returns query string parameters also in case of multiparts this can be easily fixed in the commons-fileupload filter (just adding to the parameters from the query string to the ones in the multipart form). > Replacing default multipart filter implementation (problematic > com.oreilly.servlet package license terms) > --------------------------------------------------------------------------------------------------------- > > Key: MAGNOLIA-540 > URL: http://jira.magnolia.info/browse/MAGNOLIA-540 > Project: Magnolia > Issue Type: Task > Components: core > Affects Versions: 2.1 Final > Reporter: Andreas Brenk > Assigned To: Fabrizio Giustina > Priority: Critical > Fix For: 3.1 > > Attachments: MultipartRequestFilter.java, > MultipartRequestFilterTest.java > > > The WAR file download contains Jason Hunter's com.oreilly.servlet package in > the WEB-INF/lib directory. Its license terms (see > http://servlets.com/cos/license.html) are problematic I fear. > Especially items 5 and 6 are currently violated: > "5. The distribution includes copyright notice as follows: "The source code, > object code, and documentation in the com.oreilly.servlet package is > copyright and owned by Jason Hunter." in the documentation and/or other > materials provided with the distribution. > 6. You reproduce the above copyright notice, this list of conditions, and the > following disclaimer in the documentation and/or other materials provided > with the distribution." > Both "license.txt" and "release notes.txt" contained in the WAR file download > do not mention anything demanded by the terms cited above. > A problematic second point is the license for commercial usage and > redistribution as every developer must own a copy of Jason's book or > negotiate a seperate license. > Jakarta Commons FileUpload (http://jakarta.apache.org/commons/fileupload/) is > a possible replacement at least for some functionality. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://documentation.magnolia.info/docs/en/editor/stayupdated.html ----------------------------------------------------------------
