[PATCH] Problem with using dollar sign in URLs
----------------------------------------------

                 Key: MAGNOLIA-2101
                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2101
             Project: Magnolia
          Issue Type: Bug
          Components: core
    Affects Versions: 3.5.4
            Reporter: Simon MacMullen
            Assignee: Philipp Bracher
            Priority: Minor
         Attachments: linkhelper-appendreplacement-escaping.patch

We want to be able to create URLs like "/foo/bar.html?var=${some_var}" in the 
FCK editor in Magnolia. We then post-process the content once it comes out of 
Magnolia to substitute in the variable.

Unfortunately putting a dollar sign in the URL causes 
"IllegalArgumentException: Illegal group reference" to be thrown in 
info.magnolia.cms.link.LinkHelper.convertUsingLinkTransformer() as it fails to 
escape the dollar sign before passing it as the second argument to 
Matcher.appendReplacement().

The attached patch fixes this issue and adds an extra test case for it.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------

Reply via email to