[
http://jira.magnolia.info/browse/MAGNOLIA-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668#action_16668
]
seanmctex edited comment on MAGNOLIA-2091 at 6/25/08 7:25 PM:
-----------------------------------------------------------------
While I agree that removing the Link tab is ultimately the best way to deal
with this, here's a quick patch to make it work as-is:
{code}
Index:
magnolia-editor-fckeditor/src/main/resources/info/magnolia/module/fckeditor/pages/RepositoryBrowserPageSubmit.html
===================================================================
---
magnolia-editor-fckeditor/src/main/resources/info/magnolia/module/fckeditor/pages/RepositoryBrowserPageSubmit.html
(revision 2829)
+++
magnolia-editor-fckeditor/src/main/resources/info/magnolia/module/fckeditor/pages/RepositoryBrowserPageSubmit.html
(revision 2830)
@@ -10,7 +10,9 @@
// <!--
function setURI() {
opener.SetUrl("${this.absoluteURI}");
- opener.document.getElementById('cmbLinkProtocol').value = '';
+ if ( opener.document.getElementById('cmbLinkProtocol') != null ) {
+ opener.document.getElementById('cmbLinkProtocol').value = '';
+ }
window.top.close();
}
// -->
{code}
was (Author: seanmctex):
While I agree that removing the Link tab is ultimately the best way to deal
with this, here's a quick patch to make it work as-is:
{code}
Index:
magnolia-editor-fckeditor/src/main/resources/info/magnolia/module/fckeditor/pages/RepositoryBrowserPageSubmit.html
===================================================================
---
magnolia-editor-fckeditor/src/main/resources/info/magnolia/module/fckeditor/pages/RepositoryBrowserPageSubmit.html
(revision 2829)
+++
magnolia-editor-fckeditor/src/main/resources/info/magnolia/module/fckeditor/pages/RepositoryBrowserPageSubmit.html
(revision 2830)
@@ -10,7 +10,9 @@
// <!--
function setURI() {
opener.SetUrl("${this.absoluteURI}");
- opener.document.getElementById('cmbLinkProtocol').value = '';
+ if ( opener.document.getElementById('cmbLinkProtocol') != null ) {
+ opener.document.getElementById('cmbLinkProtocol').value = '';
+ }
window.top.close();
}
// -->
MacNovel:customMagnol
{code}
> Image Linking Broken in FCKEditor
> ---------------------------------
>
> Key: MAGNOLIA-2091
> URL: http://jira.magnolia.info/browse/MAGNOLIA-2091
> Project: Magnolia
> Issue Type: Bug
> Affects Versions: 3.5.4
> Reporter: Sean McMains
> Assignee: Boris Kraft
> Fix For: 3.5.x
>
>
> To reproduce:
> # Create a new Samples: Editor paragraph
> # Within the FCKEditor pane, click the "Insert/Edit Image" button
> # The "Image Properties" window appears
> # Click the "Link" tab
> # Click the "Browse Server" button
> # Select "Website" from the "Content" popup
> # Select a page from the site hierarchy
> # Click "OK"
> Expected behavior:
> * Image should be linked to selected page
> Actual behavior:
> * Popup throws javascript error, is not closed. (Error is:
> opener.document.getElementById("cmbLinkProtocol") has no properties
> opener.document.getElementById('cmbLinkProtocol').value = '';)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------
