[ 
http://jira.magnolia.info/browse/MAGNOLIA-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918#action_16918
 ] 

Ryan Gardner commented on MAGNOLIA-1986:
----------------------------------------

That's hilarious that I forgot to have the assertJspContents throw an exception 
or make any assertions... :) (I should have followed the standard testing 
practice and verified that a bogus test case throws the exception I was 
anticipating throwing... it must have been late when I coded that)

I'm glad it was of assistance.

> Magnolia tag libraries lack unit tests
> --------------------------------------
>
>                 Key: MAGNOLIA-1986
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-1986
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: taglibs
>            Reporter: Ryan Gardner
>            Assignee: Vivian Steller
>             Fix For: 3.5.3, 3.5.x, 3.6
>
>         Attachments: AddingTaglibTest-revised.patch, AddUnitTestForOut.patch
>
>
> I've found a handful of bugs in the tag libraries that have been a real 
> nuisance to isolate. I wrote a MgnlTagTestCase to help create the necessary 
> mock objects to test the existing tags unchanged (i.e. test them as they spit 
> out content to the JspWriter - and verify that the output is what is expected)
> In the attached patch, I also have a test started for the cms:out tag - this 
> test case only covers the UUID link output that I logged in another issue ( 
> http://jira.magnolia.info/browse/MAGNOLIA-1978 )
> This change should not interfere with anything else - it just adds the 
> ability to more easily generate tests for the tag library functions. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------

Reply via email to